Prying nails correctly deconstructs reinforced boarded window #3300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new else if for reinforced window in prying nails
added them to valid targets, and can't pry while mounted
scarf005
approved these changes
Sep 28, 2023
Merged
via the queue into
cataclysmbnteam:upload
with commit Sep 28, 2023
61c1386
13 of 14 checks passed
This was referenced Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: [Balance] "Prying nails correctly deconstructs reinforced boarded window"
Purpose of change
There was no way to deconstructed a reinforced boarded window. I used the hammers pry nails function to do so.
Describe the solution
I added a new else if for the function in activity_handlers.cpp with the correct planks, nails, target terrain, and resulting terrain based on the construction recipe and the else if for boarded windows. I added it above the one for boarded window as its sequential.
Edit: I also added the two terrains to the iuse.cpp so they can be correctly targeted, and ensured you can't pry nails out while mounted.
Describe alternatives you've considered
JSONization via targeting a flag, which I can't do.
Testing
SDL is broken on compiling for me thanks to issues with the main branch. I could not test so it will need testing. This should be relatively simple and work however as its only a few lines and I rigorously copied the other else if for boarded window.
Additional context
Compiling truly be russian roulette. The day I try to learn is the day the one I choose is broken.