Fixed some issues with displaying item's mods counter #3338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olanti-p
pushed a commit
to olanti-p/Cataclysm-BN
that referenced
this pull request
Oct 6, 2023
This was referenced Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fixed some issues with displaying item's mods counter"
Purpose of change
Fixes #212. Displayed name is formed by checking long
else ifchain, and because of that mods counter could be processed partially, or skipped, or override later parts.Describe the solution
Rearranged processing order to make sure game won't skip any of mods check, nor following formatting.
Describe alternatives you've considered
Not fixing this bug.
Testing
Spawned some items, looks good.
Additional context
TOOL_ARMOR with both clothing and tool mods, and scabbard with both clothing mod and content:
