Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prettier ear/tail mutation graphics #3340

Merged

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Oct 1, 2023

Summary

SUMMARY: Content "Prettier ear/tail mutation graphics"

Purpose of change

Describe the solution

after

drew new sprites for animal ear and tail mutation. (mouse ear drawn by @NobleJake)

Describe alternatives you've considered

enjoy old graphics

before

Testing

Additional context

Co-authored-by: NobleJake <108422062+NobleJake@users.noreply.github.com>
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Oct 1, 2023
@Zireael07
Copy link
Contributor

Zireael07 commented Oct 1, 2023

The ears are not noticeably prettier (hard to judge at those sizes) BUT they moved from where a person has ears to top of head

@chaosvolt
Copy link
Member

chaosvolt commented Oct 1, 2023

Where the ears should go is a bit of a meme, but I think it does accomplish an improvement to recognition. You can actually tell it's an ear an not a weird horn. Tails also seem not changed much but having them on the same side is probably good for consistency.

EDIT: Relevant to that first bit:
9dmv2c0bpyz71

@chaosvolt
Copy link
Member

chaosvolt commented Oct 1, 2023

Also might be worth adding to the documentation before I inevitably forget.

This also reminds me that I could probably afford to split the main image's contents up into separate images containing related content (like one for shields or wearables in general, one for furniture, one for monsters, etc), since it'd make it easier to tell at a glance what the external tileset is adding stuff to, and make it more likely that two people will be able to work on separate PRs without running into each other's efforts.

@scarf005
Copy link
Member Author

scarf005 commented Oct 1, 2023

image
done.

@chaosvolt chaosvolt added this pull request to the merge queue Oct 1, 2023
Merged via the queue into cataclysmbnteam:upload with commit b94dbc9 Oct 1, 2023
6 of 12 checks passed
@scarf005 scarf005 deleted the animal-ears-and-tail-sprites branch October 1, 2023 15:25
@scarf005
Copy link
Member Author

scarf005 commented Oct 1, 2023

image

...hecc

olanti-p pushed a commit to olanti-p/Cataclysm-BN that referenced this pull request Oct 6, 2023
Co-authored-by: NobleJake <108422062+NobleJake@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add alternative ear mutation to external tileset ☂️ anime kemonomimi ear mutations
3 participants