-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(balance,port): battery consistency updates part 2 #3877
feat(balance,port): battery consistency updates part 2 #3877
Conversation
Co-Authored-By: Brennan Tekulve <14631771+batekulve@users.noreply.github.com>
Weird, tests didn't report as failed even though I forgot those. |
There's a bit of a problem with small storage batteries being 4 times larger than they used to be: some small robotics like manhacks include them. An entire manhack is just 0.75L, so the machine was 2/3 battery as it was, now where does the battery even fit? EDIT: I think it would be fine to leave small batteries as they were and instead change recipes for larger batteries to include more of them. They're cells, basic building blocks, they're supposed to be small, modular and not very useful on their own. |
Hecc, I didn't realize manhacks were smaller than the batteries, I assumed all the bots were big enough to justify fitting it somewhere. Lowering small storage batteries back down to a small amount would work if needed, only issue is as above it makes small storage batteries overlap with the same niche as medium/heavy tool batteries. An alternative would be to change any sufficiently wacky robot recipe to instead use a medium battery since that would fit the exact same volume and capacity as the battery it formerly called for. |
I think it's fine in this case. As I said, they're building blocks and are supposed to not be very useful individually.
That would make me more reluctant to spend one-use robots like grenade manhacks, with medium batteries being actually pretty valuable and useful for the player. If I need more small storage batteries, I can just gut another storage assembly from a solar car and get a shitload of them, but if I need more mediums, they're harder to get in large quantities. |
True, mediums are annoying to get. :/ EDIT: Unless...unless the chain of reduction were made to continue down even further, with (small) storage batteries being uncraftable into a pair of heavy batteries, which are already set to be uncraftable into medium batteries... |
Purpose of change
Follow-up to #3836 in which I finally mess with vehicle batteries.
Describe the solution
Ported over changes to power capacity, weight, and volume of storage batteries and car batteries from DDA, modernizing the power ratios of storage batteries based on more modern levels of power density. Went ahead and used their figures for power densities, targeting the ~0.667 kJ/g that standard tool batteries in the source PR use as well as also used by standard tool batteries in BN now. Figured this would keep them at reasonably more bulky and make the overall rarer high-capacity batteries retain that feeling of being top of the line.
Main differences I went with:
Summary of changes:
Misc changes:
Describe alternatives you've considered
Testing
Additional context
DDA PR, by @batekulve: CleverRaven/Cataclysm-DDA#57193
Checklist