Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent debugmsg while refilling liquid container with another one #4010

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

scarf005
Copy link
Member

Purpose of change

Describe the solution

check for emptiness first

Describe alternatives you've considered

rewrite liquid logic to something sane

Testing

followed steps in #4009. no debugmsg occured.

Additional context

pain

 check emptiness before removing container contents
@scarf005 scarf005 requested a review from chaosvolt December 29, 2023 02:23
@github-actions github-actions bot added the src changes related to source code. label Dec 29, 2023
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screm

@scarf005 scarf005 merged commit 552cbe5 into cataclysmbnteam:main Dec 29, 2023
12 checks passed
@scarf005 scarf005 deleted the fix-liquid-refill-errors branch December 29, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debugmsg when refilling container
2 participants