Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uncrafts for lightweight plastic containers #4204

Conversation

chaosvolt
Copy link
Member

Purpose of change

Realizing that I can't salvage gallon jugs has once again abruptly led me down a weird rabbit hole of screaming at salvage-by-weight.

Describe the solution

Since we've since decided to fudge the numbers for small underwear items and just let them be uncrafted into full rags, I added uncrafts for all plastic containers to convert them into a given number of plastic chunks (or scrap in the case of small bottles).

Describe alternatives you've considered

  1. Going the full suffering route and bumping the weights for all plastic bottles to heavier values that will translate into a reasonable number of scraps.
  2. Making it so plastic material salvages into plastic scrap instead and using that in recipes more.
  3. Making plastic chunks smol.
  4. Reverting Port over salvage-by-weight from DDA #2142 because jfc why does it constantly cause me so much suffering.
  5. Lowering how many chunks containers require to craft to commit some faint semblance of conservation of mass.

Testing

  1. Checked affected file for syntax and lint errors.
  2. Ported file change over to test build, confirmed I can now take a gallon jug apart for 12 plastic chunks.

Additional context

I loaded up DDA (old build, 2023-12-16-1905) and looked at gallon jugs, they went with the "beef the weight up" solution. However, it only returns 2 chunks when salvaged but still demands 15 chunks PLUS a polycarbonate sheet, so it's just wasteful to a wacky degree.

Checklist

Verified

This commit was signed with the committer’s verified signature.
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Feb 8, 2024
@scarf005 scarf005 merged commit 7bcf53a into cataclysmbnteam:main Feb 12, 2024
10 checks passed
@chaosvolt chaosvolt deleted the i-am-once-again-screaming-at-salvage-by-weight branch February 12, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants