Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Good bye Makeshift Arc Welder #4264

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Conversation

Lamandus
Copy link
Contributor

Purpose of change

Another life changing change from me, and that after such a long break.

The Makeshift Arc Welder (MAW) was a bit of a odd case. It was the only tool, that was craftable, and inferior to industry produced tools. Soldering iron, torches, etc. were always at the same level. Not the MAW tho. It was just sitting "in a odd place".

Describe the solution

Removal of the MAW, migrate existing MAWs to regular AWs and remove any mention of the MAW in the crafting menu. The MAW recipe produces the AW now.

This leads to following pros:
AWs can be installed into the grid, the MAW wasn't.
AWs can be used to be installed into welding rigs. It wasn't possible with the MAW.

Con:
"Unrealistic". The MAW was inferior to the AW, this is now gone. Also there is no incentive to look for a AW when the recipe is known.

Neutral:
The amount of battery used is now "unrealistically" lower. But Power wasn't that scare to get.

Describe alternatives you've considered

Get a MAW working for Grid, that would lead to a extra Slot needed for the crafting requirements, bloating it more.

Testing

Working as intended. all MAWs are gone and replaced by AWs.

Additional context

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Feb 28, 2024
Copy link
Contributor

autofix-ci bot commented Feb 28, 2024

The Autofix app has found code style violation and automatically formatted this Pull Request.

I locally edit my commits (e.g: git, github desktop)

Please choose following options:

I'd like to accept the automated commit
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

This PR is complete and I don't want to edit it anymore

It's safe to ignore this message.

I edit this PR through web UI

You can ignore this message and continue working.

I have no idea what this message is talking about

You can ignore this message and continue working. If you find any problem, please ask for help and ping @scarf005.

@scarf005 scarf005 merged commit 83ac7d2 into cataclysmbnteam:main Feb 28, 2024
10 checks passed
"id": "welder_crude",
"type": "MIGRATION",
"replace": "welder",
"flags": [ "resized_large" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pfft, welder (XL).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants