fix: mingw builds #4290
Merged
fix: mingw builds #4290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
This attempts to fix the mingw windows builds. It's 2 different fixes for 32 and 64 bit and I'm not sure either will work. Note it's the mingw builds I'm looking at here rather than the translation problems affecting the msvc build.
Describe the solution
The 32 bit fix gets rid of size_t from the lua doc because it's internally the same type as unsigned int and so conflicted. The 64 bit fix adds "-Wa,-mbig-obj" to the build flags so it won't complain that the output is too big.
Testing
None, I don't have a windows machine. I'm hoping to test it in the pipeline.