-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(UI): character preview in traits tab on character creation #5031
Conversation
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- functionality looks good.
- could also include it in debug mutation window in later PRs.
- code (tbf, entirity of rendering functions) could use a bit of refactoring in later PRs.
- windows build is failing for unknown reasons, will have to pass all tests before merging.
Co-authored-by: scarf <greenscarf005@gmail.com>
Cataclysm-BN/src/cached_options.h Lines 9 to 14 in 8eab8a6
clang-tidy has lint issues, and windows test fails. on discord it was suggested that tile_ptr null ptr reference was the cause: there's variable named |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hmm. I didn't really eyeball this until just now. I feel like it's a bit silly that the preview doesn't show any of the character's items on them, and a giant screen that takes up half the game window to barely use that space for a single sprite is both really not optimal, and at bare minimum is something that really should have an option to disable. I can also 100% see potential for complaints about not being able to disable this given people might be playing this game in situations where a naked paper doll unavoidably taking up about a quarter of the game window is going to be harder to explain to one's boss than the character sprite would be during normal gameplay... |
Well, character preview is intended to display changing character appearance based of traits. With clothes it gets less obvious that character changed somehow because it hides the skin. If you insist - i'll try to add a feature to toggle clothes on hotkey
Tried to make it scalable. Also you can scale character tile itself by pressing Z / Shift+Z to pick appropriate one. If i'll make small screen with character in the middle of great nothing it will look even weirder. If you have suggestion how to make it better please share, will try to implement.
Will implement that with "disabled" by default.
Oops. The idea that curses build incapable of referencing to cata_cursesport is quite strange. Will look what i could do about it. |
maybe we could set the panel size to 1/4 and put it on rightmost, and enable it by default (but configurable) |
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Optional
doc/
folder.Purpose of change
Character creation menu offers no way to see how your character will look in game with enabled tileset. There could be many traits that influence on character appearance. With mods there could be dozen of different hair/skin/eyes and other types of traits. And you pick that stuff only by guessing. If you don't like the result - you'll have to restart the game and try your luck again or manually edit traits ingame via debugger menu.
I'm offering to make character preview feature that will help players to immediately track character appearance changes and pick the traits they find proper.
Describe the solution
Describe alternatives you've considered
The character preview window is probably too big. I thought to add additional information to it to make it feel not so empty or to change the design but it requires some conversation.
Testing
Was able to build on windows 10 under MSYS (cmake) with help of build guide
Went through some manual tests in character creation menu and in game. Not noticed any bugs (for now).
Additional context
See a video with a showcase below: