Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): more monster-material weapons #5712

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

chaosvolt
Copy link
Member

Checklist

Required

Optional

Purpose of change

More ways to turn nasty monsters into ded killy stuff, now including a use for fungal fighter stings since wasp and bee weapons left them unloved.

Describe the solution

  1. Added sharktooth dagger and spear. Both take the same general idea that the leiomano has, being lighter while retaining comparable damage to the item they're based off of, making them focus on the niche of being more pointy than stinger weapons while stingers can debuff targets.
  2. Added a stinger spear to pair with the stinger dagger.
  3. And since stinger daggers/arrows/bolts got shifted to focus on poison instead of paralysis, as promised added triffid daggers and spears. These are counterparts to the stinger dagger/spear using a fungal fighter sting instead of a bee or wasp sting, and as expected slow victims like the old stinger weapons did.
  4. Added triffid arrows and bolts. Again using a fungal fighter sting to fill the slowing niche the stinger bolts/arrows previously filled.
  5. Added recipes for all of the above weapons.
  6. Updated UDP external tileset to sprite the new weapons, and also belatedly adding sprites for scaleskin boots and gauntlets.
  7. Misc: Fixed tooth cestus recipe having wrong crafting subcategory.
  8. Updated UDP external tileset documentation.

Describe alternatives you've considered

  1. Increasing the frequency of on-hit spells for triffid and stinger weapons from 10% to 20%.
  2. Giving the monster hunter profession a sharktooth dagger instead of a stinger dagger.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Load-tested in compiled test build.
  3. Confirmed that the spears deal out their on-hit spells even with reach attacks.
  4. Confirmed sprites are assigned correctly.

Additional context

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Nov 14, 2024
@github-actions github-actions bot added the docs PRs releated to docs page label Nov 14, 2024
Copy link
Contributor

autofix-ci bot commented Nov 14, 2024

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@RoyalFox2140 RoyalFox2140 merged commit 3ce7423 into cataclysmbnteam:main Nov 15, 2024
9 checks passed
@chaosvolt chaosvolt deleted the more-mh-weaps branch November 15, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PRs releated to docs page JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants