Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make grid plut gens deconstructible again #5743

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

RoyalFox2140
Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 commented Nov 20, 2024

Checklist

Required

Purpose of change

When I did the last PR on electrical terrain deconstruction I did a new recipe to deconstruct grid gens which was a copy paste. I didn't rename it and nobody caught it in testing that we had identical deconstructs. We also lack a test to ensure no duplicate ID's in the same document or in the main project as a whole.

Describe the solution

Add grid_ to the name of the other deconstruct

Describe alternatives you've considered

Make Chaos do it, It's graveyard day and I'm watching the dumpster fire of Stalker 2 right now.

Testing

Tests because this is trivial

Additional context

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Nov 20, 2024
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yee. I started work on a PR last night that was gonna include a fix for that but got bogged down in C++ problems trying to rig it so that the electrosenses' voltmeter function can count as a voltmeter for the sake of tool use.

@chaosvolt chaosvolt merged commit d71ccd3 into cataclysmbnteam:main Nov 20, 2024
9 checks passed
@RoyalFox2140 RoyalFox2140 deleted the fix branch November 20, 2024 18:27
@ZChris13
Copy link

ZChris13 commented Nov 27, 2024

Guys, sorry, wanna ask here.

make a new issue for it, nobody looks at merged pull requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants