Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): allow mills to hold more food than smoking racks #5747

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

chaosvolt
Copy link
Member

Checklist

Required

Optional

Purpose of change

I spent ages gathering the materials to make half a dozen wind mills, a grand army of giants whose mighty arms would be a match for the strongest of Spanish knights, only to find they only hold as much corn as a smoking rack that only takes 8 rocks and 16 planks to make.

Suggested buffing up the capacity and was told to go full send it and make it 100 liters in capacity:
image

Describe the solution

  1. In iexamine.cpp, added definition MAX_FOOD_VOLUME_MILLING to sm_rack namespace (which is also used by mills), set to 100 liters.
  2. In ther same file, changed mill_activate and iexamine::quern_examine to use MAX_FOOD_VOLUME_MILLING instead of MAX_FOOD_VOLUME, thus bumping capacity from 20 to 100 liters.

Describe alternatives you've considered

  1. Only increasing capacity to 50 liters like my very first initial idea.
  2. Sanity-checking corn because why is a single unit .75 liters jfc also that one farm variant spawns with SO GODDAMN MUCH CORN AAAAA

Testing

  1. Compiled and load-tested.
  2. Spawned in a windmill, confirmed it says I can fit 100 liters in it.
  3. Confirmed smoking racks still show 20 liters.

image

Additional context

@github-actions github-actions bot added the src changes related to source code. label Nov 22, 2024
@chaosvolt chaosvolt merged commit 4e50719 into cataclysmbnteam:main Nov 22, 2024
11 of 12 checks passed
@chaosvolt chaosvolt deleted the expand-dong branch November 22, 2024 06:20
@ZChris13
Copy link

ye I know exactly which corn farm you're talking about lol

@chaosvolt
Copy link
Member Author

I really oughta nerf that one somehow, hmmst. :>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants