Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): enhanced electric motor breaks into alloy sheets #5812

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

chaosvolt
Copy link
Member

Checklist

Required

Optional

Purpose of change

A lil thing that came up in discussion of #5805, enhanced motor's item form is made of superalloy, flavored as being lighter and more efficient than a regular motor of its size, and if made craftable likely should use superalloy in its recipe, BUT the vehiclepart returns just plain metal in its breaks_into entry.

Since balance discussion of a recipe for it is still ongoing I decided to eyeball its breakdown results in a separate PR.

Describe the solution

Changed the breaks_into entry for an installed enhanced motor, returning as many alloy sheets as it previously did steel lumps. Steel chunks removed from the breakage results outright, scrap metal was retained since it could be from other components in the motor breaking down into scrap.

Describe alternatives you've considered

  1. A comprehensive realism pass of everything that might hypothetically be in each motor when smashed, which will derail the other PR with needing components updated to be consistent, whereas this smol change will only make one recipe need to be updated for consistency (and current discussion suggests it'll soon be made to use superalloy regardless since the item uses that material anyway).
  2. Pestering the PR OP to update breakage results in the PR itself. Eh, it's already inconsistent in current main branch right this minute and a quick consistency-fix will be less likely to get held up in discussion. :>

Testing

Checked affected file for syntax and lint errors.

Additional context

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Dec 14, 2024
@chaosvolt chaosvolt merged commit e327f76 into cataclysmbnteam:main Dec 14, 2024
9 checks passed
@chaosvolt chaosvolt deleted the hulk-smash-puny-motor branch December 14, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants