Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content,port): port collapsible mop item #5836

Merged
merged 3 commits into from
Dec 27, 2024

Conversation

shmakota
Copy link
Contributor

@shmakota shmakota commented Dec 26, 2024

Checklist

Required

Optional

  • This PR ports commits from DDA or other cataclysm forks.
    • I have attributed original authors in the commit messages adding Co-Authored-By in the commit message.
    • I have linked the URL of original PR(s) in the description.

Purpose of change

ports dda change
CleverRaven/Cataclysm-DDA#55965

Describe the solution

add the collapsible mop mop_folded item, which is a smaller, rarer version of the normal mop to incentivize players to clean things like acid off the floor more often while away from home.

adds mop_folded to the relevant itemgroups, and to areas where the normal mop is found with a lower chance. the change only splits the mop spawns between these two, and does not increase the rate of mop spawns overall.

Describe alternatives you've considered

Testing

tested item and spawn locations. the mop functions as expected when used. tested the cleaning item group and the collapsible mop spawns around 40-60% as often as the normal mop.

Additional context

shmakota and others added 2 commits December 24, 2024 05:11
Co-authored-by: ZombieZilla <48612811+ZombieZilla@users.noreply.github.com>
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Dec 26, 2024
@RoyalFox2140 RoyalFox2140 merged commit b5f7b93 into cataclysmbnteam:main Dec 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants