feat: get_dataset_from_params added #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagxi
force-pushed
the
dataset_from_params
branch
3 times, most recently
from
ef2c857
to
c756ca5
Compare
Scitator
reviewed
Jun 8, 2021
bagxi
force-pushed
the
dataset_from_params
branch
3 times, most recently
from
517266a
to
ff49914
Compare
Scitator
reviewed
Jun 11, 2021
Comment on lines
18
to
+19
| def get_datasets(self, stage: str) -> "OrderedDict[str, Dataset]": | ||
| params = deepcopy(self._stage_config[stage]["loaders"]["datasets"]) |
There was a problem hiding this comment.
is it okay, that we have to use params = deepcopy(self._stage_config[stage]["loaders"]["datasets"])?
from the users perspective?
There was a problem hiding this comment.
Either deepcopy , or we should add method get_stage_config. Otherwise, there always be a chance of overwriting config params.
Scitator
reviewed
Jun 11, 2021
Scitator
reviewed
Jun 11, 2021
Comment on lines
-54
to
+66
| # kwargs for `runner.get_datasets`: | ||
| num_samples_per_class: 320 | ||
|
|
||
| datasets: | ||
| train: | ||
| _target_: MNIST | ||
| root: *dataset_root | ||
| train: True | ||
| download: True | ||
| num_samples_per_class: 320 | ||
| valid: | ||
| _target_: MNIST | ||
| root: *dataset_root | ||
| train: False | ||
| download: True |
There was a problem hiding this comment.
is it possible to run the previous Config API example without any code-changes/config-changes?
There was a problem hiding this comment.
No, dataset parameters were moved to datasets: level
bagxi
force-pushed
the
dataset_from_params
branch
from
ff49914
to
fc25268
Compare
Scitator
added a commit
that referenced
this pull request
Jun 28, 2021
* feat: get_dataset_from_params added (#1231) * feat: get_dataset_from_params (config api and hydra) added * datasets added into registry * rm @staticmethod * feat: config transforms support (#1236) * Update README.md * feat: `get_transforms` PoC * fix: HuberLoss workaround added (#1239) Co-authored-by: Sergey Kolesnikov <scitator@gmail.com> * feat: `get_samplers` from params (config API) added (#1240) * feat: support of recursive get_from_params added (#1242) * feat: support of nested lists and dicts for `registry.get_from_params` added (#1244) * feat: support of nested lists and dicts added; instantiation from path to object added * replace `_get_XXX_from_params` with `REGISTRY.get_from_params` in config API * `ConfigRunner._get_loaders_from_params` added * hydra-slayer: `meta_factory` support (#1247) * feat: support of nested lists and dicts added; instantiation from path to object added * replace `_get_XXX_from_params` with `REGISTRY.get_from_params` in config API * support of `meta_factory` for `registry.get_from_params` added Co-authored-by: Yauheni Kachan <19803638+bagxi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (checklist)
catalyst-make-codestyle && catalyst-check-codestyle(pip install -U catalyst-codestyle).make check-docs?pytest .?latestandminimalrequirements?Description
Related Issue
Type of Change
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
FAQ
Please review the FAQ before submitting an issue: