Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] MLflowLogger: fixed experiments params logging #1263

Merged
merged 11 commits into from
Jul 28, 2021

Conversation

y-ksenia
Copy link
Contributor

@y-ksenia y-ksenia commented Jul 27, 2021

Before submitting (checklist)

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide?
  • Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
  • Did you make sure to update the docs? We use Google format for all the methods and classes.
  • Did you check the docs with make check-docs?
  • Did you write any new necessary tests?
  • Did you check that your code passes the unit tests pytest . ?
  • Did you add your new functionality to the docs?
  • Did you update the CHANGELOG?
  • Did you run colab minimal CI/CD with latest and minimal requirements?

Description

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

FAQ

Please review the FAQ before submitting an issue:

@y-ksenia y-ksenia changed the title fixed experiments params logging MLflowLogger: fixed experiments params logging Jul 27, 2021
Scitator
Scitator previously approved these changes Jul 27, 2021
@Scitator
Copy link
Member

@y-ksenia could you please check the colab ci-cd? looks like there is an error, but I am not 100% sure :)

@mergify mergify bot dismissed Scitator’s stale review July 28, 2021 09:14

Pull request has been modified.

@pep8speaks
Copy link

pep8speaks commented Jul 28, 2021

Hello @y-ksenia! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-28 16:22:03 UTC

@mergify
Copy link

mergify bot commented Jul 28, 2021

This pull request is now in conflicts. @y-ksenia, could you fix it? 🙏

@y-ksenia
Copy link
Contributor Author

 fixed everything;)

@y-ksenia y-ksenia changed the title MLflowLogger: fixed experiments params logging [WIP] MLflowLogger: fixed experiments params logging Jul 28, 2021
@Scitator Scitator merged commit 4a66e28 into catalyst-team:master Jul 28, 2021
@y-ksenia y-ksenia deleted the mlflow_params_logging_fix branch July 29, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants