contrib update #793
Merged
contrib update #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scitator
added a commit
that referenced
this pull request
May 5, 2020
* Feature/checkpoint callback (#784) * CheckpointCallback: handling `save_n_best=0` * checkpoint loading moved to callback * more tests * codestyle * removed unused comments * saving checkpoint in separate method * additional check for number of files in log dir * restored loading optimizer from previous stage * removed whitespaces * tests for callbacks * by default load only best model * reset back config & updated tests * checking files to match patterns * globbing * more docs & updates according to discussion #784 * comments * additional comment * minor docs fix * fix documentation typo (#792) * contrib update (#793) * CI update * CI update 2 Co-authored-by: Dmytro Doroshenko <dimdoroshenko@gmail.com> Co-authored-by: hturki <turki.haithem@gmail.com>
lightforever
pushed a commit
that referenced
this pull request
May 5, 2020
* Feature/checkpoint callback (#784) * CheckpointCallback: handling `save_n_best=0` * checkpoint loading moved to callback * more tests * codestyle * removed unused comments * saving checkpoint in separate method * additional check for number of files in log dir * restored loading optimizer from previous stage * removed whitespaces * tests for callbacks * by default load only best model * reset back config & updated tests * checking files to match patterns * globbing * more docs & updates according to discussion #784 * comments * additional comment * minor docs fix * fix documentation typo (#792) * contrib update (#793) * CI update * CI update 2 Co-authored-by: Dmytro Doroshenko <dimdoroshenko@gmail.com> Co-authored-by: hturki <turki.haithem@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
catalyst-make-codestyle && catalyst-check-codestyle(pip install -U catalyst-codestyle).make check-docs?Description
Related Issue
Type of Change
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
You can use 'Login as guest' to see Teamcity build logs.