Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreRelese 20.05.1 #820

Merged
merged 1 commit into from
May 23, 2020
Merged

PreRelese 20.05.1 #820

merged 1 commit into from
May 23, 2020

Conversation

Scitator
Copy link
Member

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide, Pull Request section?
  • Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
  • Did you make sure to update the docs? We use Google format for all the methods and classes.
  • Did you check the docs with make check-docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

Description

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

You can use 'Login as guest' to see Teamcity build logs.

@Scitator Scitator force-pushed the pre-release/20.05.1 branch 3 times, most recently from b6ae578 to 6c7476d Compare May 23, 2020 13:21
@pep8speaks
Copy link

pep8speaks commented May 23, 2020

Hello @Scitator! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 43:1: E402 module level import not at top of file

Line 20:1: E402 module level import not at top of file
Line 21:1: E402 module level import not at top of file

Comment last updated at 2020-05-23 14:19:30 UTC

@Scitator Scitator force-pushed the pre-release/20.05.1 branch 2 times, most recently from 0f0c5b5 to 249b671 Compare May 23, 2020 13:38
@Scitator Scitator merged commit babc2b4 into master May 23, 2020
lightforever pushed a commit that referenced this pull request May 23, 2020
@Scitator Scitator deleted the pre-release/20.05.1 branch May 31, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants