Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Prevent click events during touch start #82

Merged
merged 2 commits into from
Jan 3, 2022
Merged

Conversation

catc
Copy link
Owner

@catc catc commented Dec 29, 2021

See #48, fixes #47

Also memoizes addEventListener callback functions and fixes cleanup (correctly removes listeners on dismount).

@catc
Copy link
Owner Author

catc commented Dec 29, 2021

@erpheus I changed some parts of the lib the last few days so the other PR was outdated/conflicting. Can you try this out on ios and see if it works? Seems fine for web + android

@erpheus
Copy link

erpheus commented Dec 31, 2021

Hi @catc ! Thanks for rewriting the PR. I've checked and I can replicate the behaviour with the current version of master but not with the version in this PR 😄 So I would say this is good to merge from my side.

Just for documentation here is the test I made:

In the intro.tsx I added closeOnMinuteSelect to the example Timekeeper.

Without the change I just tap once while choosing the hour and the whole watch disappears:

RPReplay_Final1640923348.mov

With the change, I tap once for the hour and then again for the minutes (and it disappears right with that tap as expected):

RPReplay_Final1640923441.mov

@catc catc merged commit b9ad0e6 into master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS events captured twice
2 participants