-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add directory to Translations to Portuguese [Incrementally] #1679
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1679 +/- ##
======================================
Coverage 83.9% 83.9%
======================================
Files 123 123
Lines 3403 3403
======================================
Hits 2855 2855
Misses 548 548 |
Codecov Report
@@ Coverage Diff @@
## master #1679 +/- ##
==========================================
+ Coverage 86.5% 87.23% +0.73%
==========================================
Files 136 136
Lines 5275 5332 +57
==========================================
+ Hits 4563 4651 +88
+ Misses 712 681 -31 |
As a small nitpick, I would prefer the subdirectories be named in locale style, that is Before the end, you will also have to update the scripts that automatically update documentation links on release. |
Ok. I'll take care for this. ;) |
Hi, any thoughts about what will happen to existing links, bookmarks, references from other project's documentation, when the existing English Markdown pages get moved to a sub-directory? Could anything be done to prevent broken links? Does github allow redirects to be set up? |
Hello! I removed the subdirectory for English documentation. Let all markdown files in docs directory and i created a pt_BR directory for docs translated, justly to keep the links on the original files. I don't know well about links management in markdown files on the Github. |
Some broken links in the index were fixed.
Merge branch 'PtBr-Translations' of https://github.com/pinho/Catch2 into PtBr-Translations
Description
[Edited] I added a directory on docs called ptbr to add the files translated from English. It may be used to provides documentation with dynamic language to external webpages, if need in the future.
My idea is to do it incrementally, until all translate files.
GitHub Issues
I commented about this in Issue #1674
Translated files