-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add versioning to shared libs #2516
Conversation
Codecov Report
@@ Coverage Diff @@
## devel #2516 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 183 183
Lines 7561 7561
=======================================
Hits 6921 6921
Misses 640 640 |
ABI stability: NOPE |
Becauase there is no ABI stability whatsoever, |
So even minor versions will potentially change ABI? That's pretty contradictory to how most ABI versioning works. Can ABI stability be maintained within X.X releases so that x.x.X can be considered bugfix only, or at least non-breaking? |
Yes. Catch2 is meant to be used as a static library. As such, it should not be installed globally and ABI stability is a non-concern. For various reasons, we also support building it as a dynamic library, but there is a number of limitations to it, e.g. symbols are exported only implicitly. Providing ABI stability is a maintenance cost I am not willing to pay. |
Thanks for the tweaks and getting this merged! |
I'm not sure what you have planned for ABI/API compatibility so versioning it to major.minor might be more appropriate than just major.