Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete all $gaTemplate instances #2435

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Delete all $gaTemplate instances #2435

merged 1 commit into from
Oct 6, 2022

Conversation

stoyan
Copy link
Contributor

@stoyan stoyan commented Oct 6, 2022

$gaTemplate is defined all over the place but not used anywhere. Delete all instances so we don't keep copying it in new code

jefflembeck
jefflembeck approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@jefflembeck jefflembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOO

@jefflembeck jefflembeck merged commit 33e201a into master Oct 6, 2022
@jefflembeck jefflembeck deleted the gaTemplate branch October 6, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefflembeck jefflembeck jefflembeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stoyan @jefflembeck