Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added collection period in CrUX Real User Measurement title. #2476

Merged
merged 2 commits into from
Oct 18, 2022

Conversation

sammeboy635
Copy link
Contributor

#2460
Added the collection period to CrUX Title.

I added some checks to make sure collectionPeriod is present. If it was not then it would revert back to the old way.

Here is "www.homedepot.com" test run with the WPT docker-compose.
crux

@stoyan
Copy link
Contributor

stoyan commented Oct 17, 2022

question: did you run composer format before you commit? Curious if it would see spacing like }else{ and turn into } else {

@sammeboy635
Copy link
Contributor Author

@stoyan I didn't run composer format, but I just added another commit to show the differences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants