Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(acct): notify cc errors #2480

Merged
merged 1 commit into from
Oct 18, 2022
Merged

feat(acct): notify cc errors #2480

merged 1 commit into from
Oct 18, 2022

Conversation

jefflembeck
Copy link
Contributor

Not the prettiest, but at least we have errors as they're passed to us. We could put together a more comprehensive and kind set of braintree errors and pass recommendations along. There's a whole list here:

https://webforcehq.zendesk.com/hc/en-us/articles/4404571172372-Braintree-Decline-Codes

Not the prettiest, but at least we have errors as they're passed to us.
We could put together a more comprehensive and kind set of braintree
errors and pass recommendations along. There's a whole list here:

https://webforcehq.zendesk.com/hc/en-us/articles/4404571172372-Braintree-Decline-Codes
const el = document.createElement('div');
el.classList.add('notification-banner', 'notification-banner__error');
el.innerText = e.detail;
document.querySelector('#notification-banner-container').appendChild(el);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will continue appending new notification divs, right? Is this desirable or we want to clean up the previous error message?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably clean it up but I want to get this out and then quickly put together something a bit better

@tkadlec tkadlec merged commit b0c5add into master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants