Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(signup): button size too small on safari #2614

Merged
merged 1 commit into from
Jan 3, 2023
Merged

fix(signup): button size too small on safari #2614

merged 1 commit into from
Jan 3, 2023

Conversation

jefflembeck
Copy link
Contributor

@jefflembeck jefflembeck commented Jan 3, 2023 •
edited
Loading

No font-size set means we're stuck with browser vendor defaults and safari says "small"

Before:

before-signup-button

After:

after-signup-button

@jefflembeck
fix(signup): button size too small on safari
79e2c73 
No font-size set means we're stuck with browser vendor defaults and
safari says "small"
stoyan
stoyan approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@stoyan stoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipshipship

tkadlec
tkadlec approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@tkadlec tkadlec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please!!

@jefflembeck jefflembeck merged commit 39ba2ab into master Jan 3, 2023
@jefflembeck jefflembeck deleted the signup-button-size branch January 3, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkadlec tkadlec tkadlec approved these changes

@scottjehl scottjehl Awaiting requested review from scottjehl

@stoyan stoyan Awaiting requested review from stoyan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jefflembeck @stoyan @tkadlec