Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show subitems in LH details #2631

Merged
merged 3 commits into from
Jan 10, 2023
Merged

Show subitems in LH details #2631

merged 3 commits into from
Jan 10, 2023

Conversation

stoyan
Copy link
Contributor

@stoyan stoyan commented Jan 9, 2023

Moved the details for its own Blade component to abstract the type switching.

One slightly irky thing is that we have empty cells now whenever items and subitems have different tds in the tr. LH gets around by not showing any vertical lines in tables.

before the change

Screenshot 2023-01-09 at 2 49 46 PM

after

Screenshot 2023-01-09 at 2 49 22 PM

LH

Screenshot 2023-01-09 at 2 49 59 PM

Stoyan Stefanov added 3 commits January 9, 2023 17:17
* We have `/snippets` and `/partials` which are synonymous
* Delete `/snippets`
* Move all LH partials together in a subdir
@stoyan
Copy link
Contributor Author

stoyan commented Jan 9, 2023

updated screenshot
Screenshot 2023-01-09 at 4 08 52 PM

@scottjehl scottjehl merged commit 5758c7a into master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants