Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bulk file uploads in favor of File Reader #2635

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Remove Bulk file uploads in favor of File Reader #2635

merged 2 commits into from
Apr 5, 2023

Conversation

stoyan
Copy link
Contributor

@stoyan stoyan commented Jan 10, 2023

  • consistent with the other textareas where we allow them to be populated from a text file
  • client side, no uploads

@stoyan
Copy link
Contributor Author

stoyan commented Jan 10, 2023

@pmeenan, wdyt? It should not affect API calls, correct?

@stoyan
Copy link
Contributor Author

stoyan commented Jan 10, 2023

before

Screenshot 2023-01-10 at 4 59 50 PM

after

Screenshot 2023-01-10 at 4 59 14 PM

@pmeenan
Copy link
Contributor

pmeenan commented Jan 10, 2023

Should be ok. Technically, it affects the api since runtest.php no longer handles bulkfile but I'd be shocked if anyone used the API for running bulk testing that way (and even more shocked if they used bulkfile). If you're using the API already, odds are you are sending each URL as a separate API call.

@pmeenan
Copy link
Contributor

pmeenan commented Jan 10, 2023

If you want to be particularly safe, remove the UI side of things but leave the handling in runtest.php alone.

@stoyan
Copy link
Contributor Author

stoyan commented Jan 10, 2023

If you're using the API already, odds are you are sending each URL as a separate API call.

yeah, or use the bulkurls

Also the API docs do not contain the word "bulk" :)

@pmeenan
Copy link
Contributor

pmeenan commented Jan 10, 2023

The one I was less sure about was the bulk tester google doc that Andy put together but it looks like it also uses the API for individual URLs: https://github.com/WebPageTest/WebPageTest-Bulk-Tester/blob/master/webpagetest.gs

I'd go ahead and remove it.

Stoyan Stefanov added 2 commits March 27, 2023 16:33
* consistent with the other textareas
* client side, no uploads
@stoyan stoyan merged commit 1987c1c into master Apr 5, 2023
@stoyan stoyan deleted the unbulk branch April 5, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants