Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(psalm): typecheck the things! #2697

Merged
merged 1 commit into from
Feb 7, 2023
Merged

feat(psalm): typecheck the things! #2697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,6 @@ jobs:

- name: Run linter
run: composer lint

- name: Run typechecker (psalm)
run: composer typecheck
7 changes: 5 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,20 @@
},
"require-dev": {
"phpunit/phpunit": "^9",
"squizlabs/php_codesniffer": "^3"
"squizlabs/php_codesniffer": "^3",
"vimeo/psalm": "^5.6"
},
"scripts": {
"format:php": "phpcbf --extensions=php,inc --standard=PSR12 --ignore=www/lib/,www/ec2/,www/resources/compiled www/ tests/ bulktest/",
"format:prettier": "npx prettier@2.7.1 --write 'www/**/*.css' 'www/**/*.js'",
"format": "composer format:php && composer format:prettier",
"typecheck": "psalm",
"lint:css": "npx stylelint@14.9.1 'www/**/*.css'",
"lint:php": "phpcs --standard=PSR12 www/src www/cpauth www/common",
"lint": "composer lint:php && composer lint:css",
"pre-autoload-dump": "Google\\Task\\Composer::cleanup",
"test": "phpunit --configuration tests/phpunit.xml"
"test": "phpunit --configuration tests/phpunit.xml",
"build": "composer typecheck && composer format && composer test"
},
"require": {
"gmostafa/php-graphql-client": "^1.13",
Expand Down
Loading