fix(ownership): creators are owners, too #2721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has the user who created the test. This isn't always the owner! Sometimes this is different in our system and this can cause an issue with private tests given how we check for an owner
Previously, only owners were owners, but also sometimes the creator of the test does not line up as the owner. This is a fix for that
jefflembeck
force-pushed
the
check-creator-for-ownership
branch
from
38a1559 to
fa7f3ea
Compare
tkadlec
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only owners were owners, but also sometimes the creator of
the test does not line up as the owner. This is a fix for that
Relies on this: #2719