Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel device update #3021

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Pixel device update #3021

merged 3 commits into from
Dec 12, 2023

Conversation

lbartoli79
Copy link
Contributor

Updated mobile_devices.ini

@lbartoli79
Copy link
Contributor Author

@pmeenan for those we set throttle_cpu=1 , do you think we are ok with this value?

@claud-io claud-io marked this pull request as ready for review December 6, 2023 11:30
@pmeenan
Copy link
Contributor

pmeenan commented Dec 6, 2023

@pmeenan for those we set throttle_cpu=1 , do you think we are ok with this value?

For the Pixel 6 and later, yes but for the earlier devices, no. The pixel 2 has a "4" throttle factor and looking at the geekbench single-threaded performance for the Pixel 3, Pixel 4 and Pixel 5, they are all less than 4x faster than the Pixel 2.

If you don't have access to actual devices to benchmark, my recommendation would be to scale the Pixel 2 throttle factor by how fast each of the other devices is relatively in geekbench.

Copy link
Contributor

@pmeenan pmeenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@claud-io claud-io merged commit 6b2468f into master Dec 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants