CustomWaterfall: add min functionality

[jspurlin]

Prior to this PR users could only set a max time to filter on when creating custom waterfalls. This meant that custom waterfalls always started at t=0 even if what you cared about didn't start until the t=5s mark

This PR adds the ability to optionally specify a min time to filter on in addition to setting a max and requests to filter on.

I verified that the custom filter scales correctly in app parts (Requests, CUP Utilization, Bandwidth, Browser Main Thread, and Long Tasks)

For example, if I care about the 5-10s range of the waterfall this is what it looks like

Before

After

This is a fix for Add ability to specify min/start time for custom waterfalls #3042

[jspurlin]

@pmeenan / @vibaldem FYI, this PR is for #3042

[arthesh]

Tagging @mjkozicki , @claud-io , would appreciate if you could review this PR and provide feedback.

[pmeenan]

LGTM.

Minimum time feels a bit off and Start seems more appropriate but given that the end is called Maximum it is appropriate to keep it aligned.

Thanks for doing this, it's been a long-standing request and I've been dreading going through the scaling code. The change looks nice and clean.

[jspurlin]

@mjkozicki ...PING... Can you review (and merge if things look good)?

[jspurlin]

@mjkozicki @claud-io ...PING, PING... Can you review (and merge if things look good)?

[claud-io]

Hello @jspurlin we are testing it, will let you know once is done. Thanks

[claud-io]

@jspurlin seems page sometimes break when min >= max or with neg numbers, can you please add check for those cases? thanks

[jspurlin]

@jspurlin seems page sometimes break when min >= max or with neg numbers, can you please add check for those cases? thanks

@claud-io Done. Also, I made sure to only use min if it was strictly < max, min === max isn't really valid. Making sure min > 0 was already being checked

[claud-io]

@jspurlin thanks, going to start testing it

[lbartoli79]

We should not draw vertical lines on first column

[jspurlin]

We should not draw vertical lines on first column

@lbartoli79 Done. I've made sure to account for the case where min is provided but max is not and not to draw vertical lines < min_ms

[jspurlin]

...PING...

@claud-io and @lbartoli79