Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Web Page Script to 25 steps #3074

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Limit Web Page Script to 25 steps #3074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6799a86
Limit Web Page Script to 25 steps
Siddhantshukla814 May 30, 2024
5ebdd23
Update settings.ini.sample
Siddhantshukla814 May 30, 2024
c3ddf49
Update settings.ini
Siddhantshukla814 May 30, 2024
1acbbb4
Update settings.ini
Siddhantshukla814 May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/local/wptconfig/settings.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ allowNonFQDN=1
enable_agent_processing=1

; Sets the maximum number of navigates in a script
maxNavigateCount=20
maxNavigateCount=25

; Selects the metric to use for the median run (defaults to loadTime)
medianMetric=SpeedIndex
Expand Down
4 changes: 2 additions & 2 deletions tests/fixtures/settings.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ allowNonFQDN=0
enable_agent_processing=1

; Sets the maximum number of navigates in a script
maxNavigateCount=20
maxNavigateCount=25

; Selects the metric to use for the median run (defaults to loadTime)
; medianMetric=SpeedIndex
Expand Down Expand Up @@ -318,4 +318,4 @@ paid_priority=0
user_priority=2
api_priority=5
bulk_priority=8
friendly_urls=1
friendly_urls=1
5 changes: 1 addition & 4 deletions www/runtest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2073,10 +2073,7 @@ function ValidateScript(&$script, &$error)

$test['navigateCount'] = $navigateCount;

$maxNavigateCount = Util::getSetting("maxNavigateCount");
if (!$maxNavigateCount) {
$maxNavigateCount = 20;
}
$maxNavigateCount = Util::getSetting("maxNavigateCount", 25);

if (!$ok) {
$error = "Invalid Script (make sure there is at least one navigate command and that the commands are tab-delimited). Please contact us if you need help with your test script.";
Expand Down
2 changes: 1 addition & 1 deletion www/settings/settings.ini.sample
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ allowNonFQDN=0
enable_agent_processing=1

; Sets the maximum number of navigates in a script
maxNavigateCount=20
maxNavigateCount=25

; Selects the metric to use for the median run (defaults to loadTime)
; medianMetric=SpeedIndex
Expand Down
Loading