Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot open menu in frameless window when devtools are not open #249

Closed
catdad opened this issue Aug 19, 2019 · 0 comments
Closed

cannot open menu in frameless window when devtools are not open #249

catdad opened this issue Aug 19, 2019 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@catdad
Copy link
Owner

catdad commented Aug 19, 2019

This only seems to happen when the window is also maximized.

[menu-isomorphic] TypeError: Error processing argument at index 1, conversion failure from 1257.2000732421875
[menu-isomorphic]     at Menu.popup (C:\Workspace\github\raw-viewer\node_modules\electron\dist\resources\electron.asar\browser\api\menu.js:77:8)
[menu-isomorphic]     at Object.openContext (C:\Workspace\github\raw-viewer\lib\menu.js:99:12)
[menu-isomorphic]     at EventEmitter.<anonymous> (C:\Workspace\github\raw-viewer\lib\isomorphic.js:45:52)
[menu-isomorphic]     at EventEmitter.emit (events.js:194:13)
[menu-isomorphic]     at WebContents.<anonymous> (C:\Workspace\github\raw-viewer\node_modules\electron\dist\resources\electron.asar\browser\api\web-contents.js:390:13)
[menu-isomorphic]     at WebContents.emit (events.js:194:13)
C:\Workspace\github\raw-viewer\lib\log.js:38 [frame] frameless app menu error Error: Error processing argument at index 1, conversion failure from 1257.2000732421875
[frame]     at EventEmitter.<anonymous> (C:\Workspace\github\raw-viewer\lib\isomorphic.js:63:23)
[frame]     at Object.onceWrapper (events.js:282:20)
[frame]     at EventEmitter.emit (events.js:194:13)
@catdad catdad added bug Something isn't working good first issue Good for newcomers labels Aug 19, 2019
catdad added a commit that referenced this issue Aug 31, 2019
…d-screens

forcing menu coordinates to integers so that they work correctly on scaled screens
@catdad catdad closed this as completed Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant