Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to electron 4 #89

Closed
catdad opened this issue Feb 12, 2019 · 2 comments
Closed

update to electron 4 #89

catdad opened this issue Feb 12, 2019 · 2 comments

Comments

@catdad
Copy link
Owner

catdad commented Feb 12, 2019

When doing so, sharp cannot be loaded, even after rebuilding with electron-rebuild. It can be loaded in the actual version of node 10, but not in electron apps.
@catdad
Copy link
Owner Author

catdad commented Feb 12, 2019

lovell/sharp#1522
electron/node-abi#55 (comment)

@catdad
Copy link
Owner Author

catdad commented Feb 22, 2019

electron-userland/electron-builder#3660

catdad added a commit that referenced this issue Apr 30, 2019
@catdad
Merge branch 'master' into #89-electron-4
9ebff23
@catdad catdad mentioned this issue Apr 30, 2019
Merged
catdad added a commit that referenced this issue May 1, 2019
@catdad
Merge pull request #143 from catdad/#89-electron-4
9c6c160 
updating to electron 4
@catdad catdad closed this as completed May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@catdad