fix(nixos): sddm package not being installed #194
Conversation
Never use attrset merge operator with `mk*` attrsets since the right hand attrset overrides the left
|
It seems that aef5672 tries to install the theme package for all versions, but set the theme only if >= 24.05. However, since the options are only made accessible if >= 24.05, there's no way to enable sddm theming at all on older versions, so I changed the module to not enable |
| @@ -13,12 +13,16 @@ let | |||
| versionAtLeast | |||
| ; | |||
| cfg = config.services.displayManager.sddm.catppuccin; | |||
| enable = cfg.enable && config.services.displayManager.sddm.enable; | |||
| enable = | |||
| versionAtLeast ctp.getModuleRelease minVersion | |||
There was a problem hiding this comment.
Why is this extra version check needed? You already can't enable cfg on versions under minVersion.
Maybe it's better to place the mkVersionedOpts on options.services.displayManager.sddm.catppuccin so you get this error
instead of this nothing happening or this error without the extra check
when trying to enable services.displayManager.sddm with a version under minVersion
There was a problem hiding this comment.
I didn't test it, but theoretically, without the version check, enable depends on config.services.displayManager.sddm.catppuccin even when it's not defined and not enabled
Never use attrset merge operator with
mk*attrsets since the right hand attrset overrides the leftFixes #192