Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(home-manager/kvantum): don't uppercase accents and flavors in override #358

Merged
merged 2 commits into from
Oct 26, 2024
Merged

fix(home-manager/kvantum): don't uppercase accents and flavors in override #358

merged 2 commits into from
Oct 26, 2024

Conversation

ryand56
Copy link
Contributor

@ryand56 ryand56 commented Oct 23, 2024

Fix for kvantum module, which uses an updated catppuccin-kvantum package that changed from uppercase enums to lowercase.

Closes #357

@ryand56 ryand56 changed the title fix(modules/home-manager/kvantum): don't uppercase accents and flavors in override fix(home-manager/kvantum): don't uppercase accents and flavors in override Oct 23, 2024
@AxerTheAxe
Copy link

I was working on a PR with these same changes but found that it does not install the kvantum theme for me. Can you confirm that the issue is fixed and that the theme correctly installs for you?

@ryand56
Copy link
Contributor Author

ryand56 commented Oct 23, 2024

I was working on a PR with these same changes but found that it does not install the kvantum theme for me. Can you confirm that the issue is fixed and that the theme correctly installs for you?

Oh yeah, theme didn't correctly install for me either.

@ryand56 ryand56 marked this pull request as draft October 23, 2024 04:20
@ryand56 ryand56 force-pushed the home-manager-kvantum-fix branch from 557f4b6 to 207a844 Compare October 23, 2024 04:34
@ryand56 ryand56 marked this pull request as ready for review October 23, 2024 04:35
@ryand56
Copy link
Contributor Author

ryand56 commented Oct 23, 2024

Now it should work.

@AxerTheAxe
Copy link

Yep, works for me. Thanks!

manuelbb-upb added a commit to manuelbb-upb/nixos that referenced this pull request Oct 23, 2024
@manuelbb-upb
Temporary input changes
89db961 
Set `nixpkgs` to follow `nixpkgs-unstable` instead of `nixos-unstable`
due to nix-community/home-manager#5991, caused
by NixOS/nixpkgs@a9e1f4e
reverted by NixOS/nixpkgs#349783
Should eventually be fixed in home-manager itself.

Also pointed `scientific-fhs` to my fork:
* new Julia versions
* work around olynch/scientific-fhs#20

Everything caused because I need this pull request
catppuccin/nix#358
for KDE theming.
isabelroses
isabelroses reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@isabelroses isabelroses left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work since catppuccin/nix supports nixpkgs 24.05 still.

@ryand56 ryand56 marked this pull request as draft October 23, 2024 16:31
@ryand56 ryand56 force-pushed the home-manager-kvantum-fix branch 2 times, most recently from fd13c6e to 7a0fedd Compare October 23, 2024 16:59
@ryand56 ryand56 marked this pull request as ready for review October 23, 2024 17:04
@ryand56
Copy link
Contributor Author

ryand56 commented Oct 23, 2024

This won't work since catppuccin/nix supports nixpkgs 24.05 still.

This should only apply now if the version is at least 24.11.

@ryand56 ryand56 force-pushed the home-manager-kvantum-fix branch from 7a0fedd to 037e2f0 Compare October 24, 2024 00:44
@AxerTheAxe
Copy link

@isabelroses sorry for the @ but this PR has been updated and is ready for review.

@isabelroses
Copy link
Member

@isabelroses sorry for the @ but this PR has been updated and is ready for review.

I can't merge but LGTM, better waiting for getchoo though.

@sgoudham
Copy link
Contributor

I can't merge but LGTM, better waiting for getchoo though.

By the power vested in me, I now pronounce you maintainer of catppuccin/nix

image

@isabelroses isabelroses merged commit 641cfc3 into catppuccin:main Oct 26, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Oct 26, 2024
Merged
@isabelroses
Copy link
Member

Thanks for the fix :)

@ryand56 ryand56 deleted the home-manager-kvantum-fix branch October 26, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabelroses isabelroses isabelroses left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Qt] Invalid accent name for Kvantum
4 participants
@ryand56 @AxerTheAxe @isabelroses @sgoudham