Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lualine): darken lualine b section for better readability #606

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

msc5
Copy link
Contributor

@msc5 msc5 commented Nov 1, 2023

🎉 First off, thanks for taking the time to contribute! 🎉

Here are some guidelines:

  • Format code using stylua.
  • New plugin integration should be added in alphabetical order:
  • Create a topic branch on your fork for your specific PR.
  • Use conventionalcommits.org's
    rules for explicit and meaningful commit messages.
  • If it's your first time contributing to a project, then read
    About pull requests
    on Github's docs.

Here are some tips:

  • Use vim.g.catppuccin_debug = true to get live config re-loading

@vollowx vollowx changed the title style(lualine): darken lualine b section for better readability feat(lualine): darken lualine b section for better readability Nov 4, 2023
@nullchilly
Copy link
Contributor

Before

image

image

This proposal

image

image

My take

image

image

IMO the previous lualine b section is indeed a bit harsh on the eyes. However, deleting the bg will make the section obsolete, e.g. Take a look at the lualine sections:

+-------------------------------------------------+
| A | B | C                             X | Y | Z |
+-------------------------------------------------+

After removing the bg for B it feels like:

+-------------------------------------------------+
| A | C                             X | Z |
+-------------------------------------------------+

With the above points I will strike in the middle and only darken the b section from surface1 to surface0

@nullchilly nullchilly merged commit 32ee05d into catppuccin:main Dec 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants