Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(diffview): add diffview integrations #700

Merged
merged 3 commits into from
May 8, 2024

Conversation

m00p1ng
Copy link
Contributor

@m00p1ng m00p1ng commented Apr 30, 2024

Added integration for diffview.nvim

Before
Screenshot 2024-04-30 at 16 50 45

After
Screenshot 2024-04-30 at 16 53 10

@mrtnvgr
Copy link
Contributor

mrtnvgr commented May 4, 2024

I can't figure out what was changed based on these screenshots, they look identical for me 😕

Documentation should have same value as in `init.lua` defaults :)
@vollowx
Copy link
Collaborator

vollowx commented May 4, 2024

I can't figure out what was changed based on these screenshots, they look identical for me 😕

@mrtnvgr The M at the signcolumn of the sidebar has been yellow following the 'modified color', and the title at the sidebar has been mauve following the theme color, as I can see.

Copy link
Contributor

@mrtnvgr mrtnvgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@vollowx vollowx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside this LGTM ❤️

lua/catppuccin/groups/integrations/diffview.lua Outdated Show resolved Hide resolved
lua/catppuccin/groups/integrations/diffview.lua Outdated Show resolved Hide resolved
lua/catppuccin/groups/integrations/diffview.lua Outdated Show resolved Hide resolved
@mrtnvgr mrtnvgr merged commit 182f256 into catppuccin:main May 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants