refactor: use whiskers, adjust catppuccin-latte & add comments
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncenter
commented
Jun 7, 2024
sgoudham
reviewed
Aug 31, 2024
There was a problem hiding this comment.
Surprising that Latte upstream has the same fg and bg, I wonder what elements that affects? Feels like it should be super noticable.
Worth noting that we should upstream this back up but I'd like to test the theme first, especially Latte cause I'm curious.
Have you tested it already? @uncenter
|
I've tested macchiato but not latte. I'll try that now. |
sgoudham
approved these changes
Aug 31, 2024
Makes it easier to diff against the upstream version
sgoudham
approved these changes
Aug 31, 2024
sgoudham
changed the title
catppuccin-latte & add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Whiskers, Catppuccin's in-house templating tool, to build the themes. The theme file here was removed when it was upstreamed (#7), this PR returns it to this repository - now built with Whiskers. Edit the
zellij.terafile and then runjust buildto build the output theme. You will need Whiskers (linked above) and optionally Just installed.Note: I first added the upstream theme file from https://github.com/zellij-org/zellij/blob/ff36798c9e52c9c73111afd03c9a69ecb1aee073/zellij-utils%2Fassets%2Fthemes%2Fcatppuccin.kdl, and then uploaded the new Whiskerified themes for comparison - see
49e5eef(#11) for an ideal diff.