Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile and make.sh improvements #8

Closed
8 tasks done
cav94mat opened this issue Jul 14, 2020 · 0 comments
Closed
8 tasks done

Makefile and make.sh improvements #8

cav94mat opened this issue Jul 14, 2020 · 0 comments
Assignees
@cav94mat
Labels
enhancement Improvement proposal
Milestone
0.9a

Comments

@cav94mat
Copy link
Owner

cav94mat commented Jul 14, 2020 •
edited
Loading

Makefile

  • Add make test rule
  • Add constant for the target image name (IMAGE=cav94mat/docker-maintenance), to pass to make.sh
  • Add constant for the sideload output file (SIDELOAD=docker-sideload.tar)
  • Add constant for the build number (BUILD=0.Xa), to pass to make.sh
  • make clean should take down the test stack, if it is still up

Make.sh scripts

  • Add test op
  • Take in $IMAGE from the makefile
  • Pass $IMAGE in the readonly constant $fork_image in the output script
@cav94mat cav94mat self-assigned this Jul 14, 2020
@cav94mat cav94mat added the enhancement Improvement proposal label Jul 14, 2020
@cav94mat cav94mat changed the title Makefile improvements Makefile and make.sh improvements Jul 20, 2020
@cav94mat cav94mat added this to the 0.9a milestone Jul 20, 2020
cav94mat added a commit that referenced this issue Jul 20, 2020
@cav94mat
Rel 0.9a (#6, #7, #8, #9, #10, #11, #12)
0fbe017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cav94mat cav94mat

Labels
enhancement Improvement proposal
Projects
None yet
Milestone
0.9a
Development

No branches or pull requests
1 participant
@cav94mat