Docker compose ci update #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y_train is a np.array, we can pass a list of indexes directly to the operator[]. X_train is a dataframe, and our sample_idx is a list of randomly sampled integers between [0, len(X_train)), so we should operate with iloc.
This is probably something we want to make a conditional check to run when pushing to master branch, but not docker-compose. Right now, as we do not have plans on merging this branch, I think we can leave as it is. I will open an issue regarding this.
|
I am currently working on the CI and will perform a squash as soon as this works properly |
|
Merging, as there are open PRs to fix the algorithms failing in the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Updates workflow to run on PR in docker-compose branch. I will manually trigger the workflow for current open PRs using github UI upon approval.
Also, it fixes the
test_populationscript as noticed by @@gbomarito in his PR #188. The reason it fails now is that y_train is a np.array, we can pass a list of indexes directly to the operator[].X_train is a dataframe, and our sample_idx is a list of randomly sampled integers between [0, len(X_train)), so we should operate with iloc.