Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added getRooms #19

Merged
merged 1 commit into from
Dec 4, 2013
Merged

added getRooms #19

merged 1 commit into from
Dec 4, 2013

Conversation

Dshankar
Copy link
Contributor

@Dshankar Dshankar commented Dec 3, 2013

Example use cases:

  1. A chat app that lists all the "chat lobbies" that a user may join
  2. User wants to create a new "chat lobby" but it needs to be unique. This allows the app to lookup existing lobbies to verify uniqueness.

@cayasso
Copy link
Owner

cayasso commented Dec 4, 2013

I will merge this in but will do some changes to leverage existing api.

cayasso added a commit that referenced this pull request Dec 4, 2013
@cayasso cayasso merged commit b9525b9 into cayasso:master Dec 4, 2013
@cayasso
Copy link
Owner

cayasso commented Dec 4, 2013

@Dshankar check this commit c4d4d6f it basically add rooms method which already exist on the spark to the server (primus)

primus.rooms(); // get all active rooms

or

primus.rooms(spark) // get the rooms spark is in

Thanks again for your initiative

Will be releasing new version soon.

@Dshankar
Copy link
Contributor Author

Dshankar commented Dec 4, 2013

I wrote some tests as well but didn't merge. I see that you have done so already! Nice work, and thanks for a great lib!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants