Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store dependencies' versions with godep #235

Merged
merged 1 commit into from
Apr 23, 2015
Merged

store dependencies' versions with godep #235

merged 1 commit into from
Apr 23, 2015

Conversation

jzelinskie
Copy link
Contributor

These dependencies can be loaded into your $GOPATH simply executing
godep get. This will allow builds to become reproducible, without
getting in the way of those wanting to consume parts of the project's
source code as a library.

As per the discussion in #234.

@jzelinskie
Copy link
Contributor Author

If this sounds good to everyone, I can go ahead and update .travis.yml to use this method to create builds, this way we can know that the dependencies are always maintained.

@kortschak
Copy link
Contributor

LGTM

@barakmich
Copy link
Member

Yeah. Given the Cayley-as-a-library notion, this is probably the right net answer. .travis.yml support is probably a good idea too!

@jzelinskie
Copy link
Contributor Author

Looks like godep get is restoring all but the mathutil package. I'll continue to look into it tomorrow, as it's gotten pretty late.

@jzelinskie
Copy link
Contributor Author

I really should also write something for the docs, as changing a dependency requires executing godep save --copy=false ./... and loading the vendored dependencies in your $GOPATH requires executing godep restore

@jzelinskie
Copy link
Contributor Author

Looks like godep was hanging on the tip build; likely related to tools/godep#206

@kortschak
Copy link
Contributor

Note also this recent post https://groups.google.com/d/topic/golang-nuts/G0HO7sEsIQQ/discussion

Maybe we could hold off until a canonical dep file format is actually decided in the nuts thread I linked #234.

@jzelinskie
Copy link
Contributor Author

If it wasn't for there being an issue with tip, I would argue that having this merged now hurts no one and only gives us the benefit of having reproducible builds until the Go team figures out what they want to do.

I don't know how long it's going to take them, but I hope it's sooner rather than later.

These dependencies can be loaded into your $GOPATH simply executing
`godep restore`. This will allow builds to become reproducible, without
getting in the way of those wanting to consume parts of the project's
source code as a library.
@jzelinskie
Copy link
Contributor Author

Rebased into one commit. The issue with tip seems to be resolved now.

@kortschak
Copy link
Contributor

kortschak commented Apr 23, 2015 via email

barakmich added a commit that referenced this pull request Apr 23, 2015
store dependencies' versions with godep
@barakmich barakmich merged commit 46093c2 into cayleygraph:master Apr 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants