Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt1.3.2 #38

Merged
merged 4 commits into from
Sep 26, 2019
Merged

sbt1.3.2 #38

merged 4 commits into from
Sep 26, 2019

Conversation

takayahilton
Copy link
Contributor

No description provided.

@cb372
Copy link
Owner

cb372 commented Sep 11, 2019

Thanks!

The no-unused-no-undeclared-classifier test is failing with sbt 1.3.0. I guess some behaviour has changed in sbt between 1.2.8 and 1.3.0.

@takayahilton
Copy link
Contributor Author

sbt now uses coursier since 1.3.0, so that is why failed.

.travis.yml Outdated
@@ -7,7 +7,7 @@ matrix:
- env: SBT_VERSION="0.13.18"
scala: 2.10.7

- env: SBT_VERSION="1.2.8"
- env: SBT_VERSION="1.3.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep sbt 1.2.8 in the matrix and also add 1.3.0. I'd like to make sure all the tests pass for both 1.2.8 (which uses Ivy) and 1.3.0 (which uses Coursier).

@takayahilton takayahilton changed the title sbt1.3.0 sbt1.3.2 Sep 24, 2019
Copy link
Owner

@cb372 cb372 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry I forgot about your PR

@cb372 cb372 merged commit b7e2ade into cb372:master Sep 26, 2019
@takayahilton takayahilton deleted the sbt1.3.0 branch September 26, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants