Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github actions CI #90

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Github actions CI #90

merged 3 commits into from
Dec 1, 2020

Conversation

keynmol
Copy link
Contributor

@keynmol keynmol commented Nov 28, 2020

Closes #89

🤷‍♂️ Something seems to be running. It shouldn't be this simple :D

https://github.com/keynmol/sbt-explicit-dependencies/runs/1467709269

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@cb372
Copy link
Owner

cb372 commented Dec 1, 2020

Nice! Not sure why the workflow didn't run against the PR though. Maybe it doesn't start working until the workflows file is in the master branch?

You may as well delete .travis.yml as part of this PR.

@keynmol
Copy link
Contributor Author

keynmol commented Dec 1, 2020

@cb372 not sure tbh, may be there are some settings that need to be changed for PRs from forks?

@keynmol
Copy link
Contributor Author

keynmol commented Dec 1, 2020

I'm also going to add coursier cache action, as I don't think the dependencies of this plugin are likely to change very often and it should help save time on builds

Copy link
Owner

@cb372 cb372 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge and see what happens

@cb372 cb372 merged commit c3d3584 into cb372:master Dec 1, 2020
@keynmol keynmol deleted the github-actions branch December 1, 2020 12:36
@keynmol
Copy link
Contributor Author

keynmol commented Dec 1, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to GitHub Actions
2 participants