1.0.4 CRAN release (#71)

cb4ds · Nov 7, 2023 · 0c5da78 · 0c5da78
1 parent fc30410
commit 0c5da78
Show file tree

Hide file tree

Showing 8 changed files with 17 additions and 7 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: periscope
 Type: Package
 Title: Enterprise Streamlined 'Shiny' Application Framework
-Version: 1.0.2
+Version: 1.0.4
 Authors@R: c(
     person("Constance", "Brett", email="connie@aggregate-genius.com", role = c("aut", "cre")),
     person("Isaac", "Neuhaus", role = "aut", comment = "canvasXpress JavaScript Library Maintainer"),

diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,11 @@
 #Revisions and Change Log
 
+#### v1.0.4
+* Minor bugfix for reactive return on downloadableTables when using initial selections
+
+#### v1.0.3
+* Resolved outstanding Roxygen 7+ issue: https://github.com/r-lib/roxygen2/issues/1491
+
 ### v1.0.2
 * Minor bugfixes - handled classes and packageversion checking in compliance with latest R requirements to resolve notes
 

diff --git a/R/downloadFile.R b/R/downloadFile.R
@@ -280,7 +280,7 @@ download_file <- function(input,
                     show_rownames <- attr(data, "show_rownames")
                     openxlsx::write.xlsx(data, file, 
                                          asTable   = TRUE, 
-                                         row.names = !is.null(show_rownames) && show_rownames)
+                                         rowNames = !is.null(show_rownames) && show_rownames)
                 }
             } else {
                 writexl::write_xlsx(data, file)

diff --git a/R/downloadableTable.R b/R/downloadableTable.R
@@ -275,6 +275,7 @@ download_table <- function(input, output, session,
             dtInfo$selection <- NULL
         }
         dtInfo$selection <- result
+        dtInfo$selected  <- rownames(result)
     })
 
     shiny::observe({

diff --git a/R/periscope.R b/R/periscope.R
@@ -38,6 +38,7 @@
 #' @docType package
 #'
 #' @name periscope
+#' @aliases periscope-package
 NULL
 
 .g_sdp_installed <- FALSE

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,6 +1,6 @@
 ## Comments from Maintainer
 
-Bugfixes for the changes in utils::packageVersion and class checks in the package and tests
+Updated package documentation per issue instructions
 
 ---  
 
@@ -10,7 +10,7 @@ Bugfixes for the changes in utils::packageVersion and class checks in the packag
 RStudio Server Pro (Ubuntu 20.04)
 * R 4.0.5
 * R 4.2.3
-* R 4.3.0
+* R 4.3.1
 
 CircleCI
 

diff --git a/man/periscope.Rd b/man/periscope.Rd
diff --git a/vignettes/new-application.Rmd b/vignettes/new-application.Rmd
@@ -20,7 +20,7 @@ vignette: >
 This framework was created for the express purpose of making it easy for shiny
 developers to create consistent-looking and functioning applications.  This is
 important because it reduces the time a user must spend to learn the interface
-for new applications (this reducing application support time and increasing 
+for new applications (thus reducing application support time and increasing 
 the user's satisfaction across applications).
 
 In addition to creating a consistent UI experience this framework reduces
@@ -59,7 +59,8 @@ add tabbed pages, etc.
 
 The right sidebar is, like the left sidebar, reserved for configuration options, settings, 
 and general user application controls and functionality that will affect the body of the
-application.  
+application.
+
 Users can create their own tabs in the right sidebar up to a maximum of 5.
 
 The right sidebar is collapsed by default, it can be opened by clicking on the (customizable) icon.
@@ -175,7 +176,7 @@ Different parts of the generated application can be customized with a custom yam
 This is a high-functionality set of custom-styled buttons with the built-in 
 ability to download data in different file formats.
 
-*See the downloadFileButton Vignette for more detailed information*
+*See the downloadFile Vignette for more detailed information*
 
 #### downloadableTable