Bugfix for error when sdp is uninstalled #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## cran #51 +/- ##
=======================================
Coverage 78.25% 78.25%
=======================================
Files 12 12
Lines 1159 1159
=======================================
Hits 907 907
Misses 252 252
Continue to review full report at Codecov.
|
agenius-mohammed-ali
suggested changes
Mar 31, 2021
| @@ -148,7 +148,7 @@ create_new_application <- function(name, location, sampleapp = FALSE, resetbutto | |||
| } | |||
| } | |||
|
|
|||
| if (!(.g_sdp_installed)) { | |||
| if (!(.g_sdp_installed) && dashboard_plus) { | |||
There was a problem hiding this comment.
no need for these extra brackets , just !.g_sdp_installed && dashboard_plus will be enough
There was a problem hiding this comment.
True - but I prefer more parenthesis than not, so I think this is fine.
agenius-mohammed-ali
approved these changes
Mar 31, 2021
cb4ds
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://3.basecamp.com/3775257/buckets/16956142/todos/3606846770
https://3.basecamp.com/3775257/buckets/16956142/todos/3598578613