Fix ReadTransaction::close() #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it always returned ReadTransactionStillInUse
adamreichold
reviewed
Jun 2, 2024
| @@ -1298,7 +1296,9 @@ impl ReadTransaction { | |||
| /// | |||
| /// Returns `ReadTransactionStillInUse` error if a table or other object retrieved from the transaction still references this transaction | |||
| pub fn close(self) -> Result<(), TransactionError> { | |||
| if Arc::strong_count(&self.transaction_guard) > 1 { | |||
| let cloned = self.tree.clone_transaction_guard(); | |||
There was a problem hiding this comment.
As an alternative, one could have added an accessor like
fn transaction_guard(&self) -> &Arc<TransactionGuard>;to avoid the unnecessary clone here. The cloning itself could then still just be written as
Arc::clone(self.tree.transaction_gurard())without adding another method.
There was a problem hiding this comment.
Oh ya, that's cleaner. #814
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it always returned ReadTransactionStillInUse
Fixes #812