Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind silo-input-transformer into sr2silo transform to ndjson #46

Closed
Tracked by #45
gordonkoehn opened this issue Nov 26, 2024 · 2 comments · Fixed by #51
Closed
Tracked by #45

Bind silo-input-transformer into sr2silo transform to ndjson #46

gordonkoehn opened this issue Nov 26, 2024 · 2 comments · Fixed by #51
Assignees
Labels
enhancement New feature or request

Comments

@gordonkoehn
Copy link
Collaborator

gordonkoehn commented Nov 26, 2024

Download and bind Fabian's sr2silo into sr2silo and make a docker to add to the docker-compose.

@gordonkoehn gordonkoehn added the enhancement New feature or request label Nov 26, 2024
@gordonkoehn gordonkoehn self-assigned this Nov 26, 2024
@gordonkoehn gordonkoehn linked a pull request Nov 26, 2024 that will close this issue
@gordonkoehn gordonkoehn linked a pull request Nov 29, 2024 that will close this issue
@gordonkoehn
Copy link
Collaborator Author

Works !! We can now generate ndjson for SILO from wastewater data ! Thanks to Fabian Engenniederhammer's instant support.

@gordonkoehn
Copy link
Collaborator Author

  • check if the insertions file from David works or not ?
  • check what inputs my nextcladed translation really uses, it doesn't use the insertions from David correct only sequences

It is probably best to refactor this PR and merge with Nexclade while still realigning.

Do a next PR to optimize for no realignments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant