Refactor Library #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxicapodacqua
requested changes
Feb 27, 2024
Comment on lines
+132
to
+134
| //TODO pedir que me de un prompt mejorado del picto a mejorar | ||
| //https://platform.openai.com/docs/guides/prompt-engineering | ||
| //https://learnprompting.org/es/docs/intro Imageprompting |
There was a problem hiding this comment.
Add a tech debt issue for this
There was a problem hiding this comment.
@hectoritr Can you create this issue?
shayc
requested changes
Feb 27, 2024
| id: data[0].id, | ||
| text: data[0].text, | ||
| locale: data[0].language, | ||
| picto: data.map((picto: any) => picto.picto.image_url), |
There was a problem hiding this comment.
any should be replaced with the actual type. Or just be removed if data variable is already typed.
There was a problem hiding this comment.
How can i deal with this, if the data is a third party API response? I will create an issue of this.
issue #3
| })); | ||
|
|
||
| return pictogramsList; | ||
| } catch (error: Error | any) { |
There was a problem hiding this comment.
I get Catch clause variable type annotation must be 'any' or 'unknown' if specified. if delet it. Which one is fits better in this case? any or unknow
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.